-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer hexadecimal representation of O_TMPFILE on linux-sparc64 #920
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
8 zeros in octal is |
Right, I completely forgot about octal and was somewhat surprised it worked ;). Probably makes sense to rephrase the commit message. |
@bors: r+ |
📌 Commit a9cddbc has been approved by |
Prefer hexadecimal representation of O_TMPFILE on linux-sparc64 While working on the libc bindings for sparc-linux, I stumbled across this typo in the O_TMPFILE definition on linux-sparc64. Compare with: > https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/unix/sysv/linux/sparc/bits/fcntl.h;hb=16efad5171ac1ac2c8728405f2703045f08c494b#l42 > https://sources.debian.org/src/glibc/2.26-6/sysdeps/unix/sysv/linux/sparc/bits/fcntl.h/#L42 CC @jrtc27
☀️ Test successful - status-appveyor, status-travis |
While working on the libc bindings for sparc-linux, I stumbled across this typo in the O_TMPFILE definition on linux-sparc64.
Compare with:
CC @jrtc27